Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Steps can be increamented with - Semitone, Tone, Octave. According to choice of user #822

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sohamm20
Copy link

@sohamm20 sohamm20 commented Nov 8, 2024

Screenshot 2024-11-08 at 9 35 24 PM

@frostburn
Copy link
Member

Was there community demand for this?
I personally think this just adds clutter.
We can have it, but please put it behind a preference that's off by default.

@sohamm20
Copy link
Author

sohamm20 commented Nov 9, 2024

Can you give suggestions on how to add it as a preference?

midiNoteNumberToName(scale.baseMidiNote, -1, scale.accidentalPreference)
}}</span>

<span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a while since I've programmed Vue, but it's something along the lines of adding the new preference, const state = useStateStore() and replacing this line with: <span v-if="state.showMidiStepVariants">.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants